Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(bundle): treeshake options API #2352

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

ferferga
Copy link
Member

@ferferga ferferga commented May 17, 2024

This reduces bundle size and perhaps (not measured) improves performance by not having the unnecessary abstractions of Options API:

Checklist

  • Drop Vuetify
  • Custom Vue components around Swiper
  • Ensure route guards in playback pages (music and video) still work properly
  • Find other usages of defineOptions that might have been added after this description has been written.

@jellyfin-bot
Copy link

jellyfin-bot commented May 17, 2024

Cloudflare Pages deployment

Latest commit 737860a
Status ✅ Deployed!
Preview URL https://274d7ef8.jf-vue.pages.dev
Preview alias https://test-bundle-reduction.jf-vue.pages.dev
Type 🔀 Preview

View build logs

Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ferferga ferferga added the blocked Something depends on another issue or Pull Request label May 18, 2024
@ferferga ferferga force-pushed the test-bundle-reduction branch from 331f581 to ab77945 Compare June 19, 2024 19:08
Copy link

sonarcloud bot commented Jun 19, 2024

@ferferga ferferga force-pushed the master branch 15 times, most recently from acb6ecf to 5d6a7c8 Compare August 11, 2024 11:13
@jellyfin-bot jellyfin-bot added the merge conflict Something has merge conflicts label Sep 6, 2024
@ferferga ferferga force-pushed the master branch 2 times, most recently from c360429 to f3260d9 Compare September 6, 2024 13:57
@ferferga ferferga force-pushed the master branch 4 times, most recently from 0babd7c to 039e205 Compare October 3, 2024 22:38
@ferferga ferferga force-pushed the master branch 5 times, most recently from fe041a3 to 3fbf550 Compare October 3, 2024 23:53
@ferferga ferferga marked this pull request as draft November 6, 2024 22:57
@ferferga ferferga force-pushed the test-bundle-reduction branch from ab77945 to 9d8eb0b Compare November 6, 2024 23:01
@jellyfin-bot jellyfin-bot removed the merge conflict Something has merge conflicts label Nov 6, 2024
@ferferga ferferga force-pushed the test-bundle-reduction branch from 9d8eb0b to 737860a Compare November 6, 2024 23:09
Copy link

sonarcloud bot commented Nov 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something depends on another issue or Pull Request
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants